Krm/tink server #573
Merged
Krm/tink server #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahhausler
force-pushed
the
krm/tink-server
branch
from
d60b502
to
2ed353d
Compare
micahhausler
force-pushed
the
krm/tink-server
branch
from
2ed353d
to
a82ae63
Compare
Codecov Report
@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 45.86% 44.39% -1.48%
==========================================
Files 56 61 +5
Lines 3268 3489 +221
==========================================
+ Hits 1499 1549 +50
- Misses 1686 1857 +171
Partials 83 83
Continue to review full report at Codecov.
|
micahhausler
force-pushed
the
krm/tink-server
branch
9 times, most recently
from
b679144
to
418b8b8
Compare
mergify bot
added a commit
that referenced
this pull request
Apr 4, 2022
## Description * Externalized worker package for testability * Created `ContainerManager` and `ContainerLogger` abstractions * Added tests for new interfaces * Cleaned up worker method arguments (logger is now passed via context) * Left worker logic unchanged * Refactored `Worker` struct and initialization ## Why is this needed I was working on #573 and wanted to be able to create a 'virtual worker' with faked-out Docker client calls. This refactor will make it easy immediately test API changes and later refactor the worker logic. ## How Has This Been Tested? * Tested locally with a workflow * Added unit tests ## How are existing users impacted? What migration steps/scripts do we need? No impact to existing users ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [x] added unit or e2e tests - [ ] provided instructions on how to upgrade
micahhausler
force-pushed
the
krm/tink-server
branch
from
418b8b8
to
16639c2
Compare
micahhausler
force-pushed
the
krm/tink-server
branch
from
16639c2
to
4be71dd
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
micahhausler
force-pushed
the
krm/tink-server
branch
from
4be71dd
to
8387611
Compare
thebsdbox
previously approved these changes
Apr 7, 2022
mmlb
previously approved these changes
Apr 15, 2022
There was a problem hiding this comment.
skipped over virtual-worker stuff and everything else looks alright. Haven't really used bdd style tests and tooling but if that works for you then 👍. server is looking pretty big, we should split it up so the k8s and sql backends are separate subpackages later I think.
|
I've added do-not-merge just until #602 is merged. |
micahhausler
force-pushed
the
krm/tink-server
branch
from
8387611
to
3d7ac1d
Compare
micahhausler
force-pushed
the
krm/tink-server
branch
from
3d7ac1d
to
e064472
Compare
micahhausler
force-pushed
the
krm/tink-server
branch
6 times, most recently
from
6efd3d7
to
f80d5fa
Compare
mmlb
reviewed
Apr 25, 2022
micahhausler
force-pushed
the
krm/tink-server
branch
from
f80d5fa
to
2a8c9a6
Compare
* Add e2e ginkgo tests Signed-off-by: Micah Hausler <[email protected]>
micahhausler
force-pushed
the
krm/tink-server
branch
from
2a8c9a6
to
cc49e78
Compare
mmlb
approved these changes
Apr 26, 2022
mmlb
added
ready-to-merge
displague
approved these changes
Apr 26, 2022
| @@ -60,6 +60,7 @@ func NewRootCommand(version string, logger log.Logger) *cobra.Command { | |||
| logger, | |||
| tinkWorker.WithMaxFileSize(maxFileSize), | |||
| tinkWorker.WithRetries(retryInterval, retries), | |||
| tinkWorker.WithDataDir("./worker"), | |||
There was a problem hiding this comment.
I realize the virtual-worker has limited use-cases, but perhaps --data-dir could be added with ./worker as the default.
| }, | ||
| wantErr: nil, | ||
| }, | ||
| { |
There was a problem hiding this comment.
Perhaps we can also test Global Timeout.
| return nil, errNotImplemented | ||
| } | ||
|
|
||
| // ListWOrkflows will return a not implemented error. |
There was a problem hiding this comment.
Suggested change
| // ListWOrkflows will return a not implemented error. | |
| // ListWorkflows will return a not implemented error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Kubernetes API backend to Tinkerell as a replacement for Postgres.
This PR builds on #563 and adds new API capabilities
Why is this needed
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: