Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use db.Database interface in grpc server #569

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

micahhausler
Copy link
Contributor

Signed-off-by: Micah Hausler [email protected]

Description

Use the interface type instead of the concrete type

Why is this needed

Prep work for Tink API using Kubernetes Resource Model

Fixes:
N/A

How Has This Been Tested?

Ran tests/verify locally

How are existing users impacted? What migration steps/scripts do we need?

N/A

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #569 (a417791) into main (6e66633) will not change coverage.
The diff coverage is n/a.

❗ Current head a417791 differs from pull request most recent head 9ce724f. Consider uploading reports for the commit 9ce724f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   34.76%   34.76%           
=======================================
  Files          44       44           
  Lines        3348     3348           
=======================================
  Hits         1164     1164           
  Misses       2085     2085           
  Partials       99       99           
Impacted Files Coverage Δ
grpc-server/grpc_server.go 35.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e66633...9ce724f. Read the comment docs.

mmlb
mmlb previously approved these changes Dec 9, 2021
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Dec 9, 2021
@mergify mergify bot merged commit b89f887 into tinkerbell:main Dec 9, 2021
@micahhausler micahhausler deleted the database/type-change branch December 9, 2021 20:42
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants