tink-worker: do not attach the action container stdout/stderr to the current process when --capture-action-logs=false #549
Conversation
when tink-worker is configured with --capture-action-logs=false the action container stdout/stderr must not be attached to the current process. that configuration is used when there is an existing docker log-driver, which will capture all the containers logs without tink-worker help. this prevents the action container logs from being duplicated in the tink-worker container logs and in the action container docker logs. Signed-off-by: Rui Lopes <[email protected]>
rgl
force-pushed
the
rgl-fix-capture-actions-logs
branch
from
0404155
to
c362740
Compare
Codecov Report
@@ Coverage Diff @@
## main #549 +/- ##
=======================================
Coverage 34.76% 34.76%
=======================================
Files 44 44
Lines 3348 3348
=======================================
Hits 1164 1164
Misses 2085 2085
Partials 99 99
Continue to review full report at Codecov.
|
|
This seems reasonable to me, but I don't have all the context. The branch needs to be updated too. |
@rgl are you still interested in working on this? |
|
@nshalman, is there anything else needed in this PR? |
I guess I could theoretically update the branch for you. |
|
@nshalman when there are no conflicts, why is there a need to rebase/merge master into the PR? |
Looks like there wasn't. My mistake. Thank you! |
Description
when tink-worker is configured with --capture-action-logs=false the action
container stdout/stderr must not be attached to the current process.
that configuration is used when there is an existing docker log-driver, which
will capture all the containers logs without tink-worker help.
Why is this needed
this prevents the action container logs from being duplicated in the
tink-worker container logs and in the action container docker logs.
How Has This Been Tested?
I've manually tested this locally.
How are existing users impacted? What migration steps/scripts do we need?
No impact is expected.
Checklist:
I have: