Tink Server: Fix runtime panic #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ady set and may not be reset The grpc server interceptors need to be chained to not cause a runtime panic. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 33.59% 33.61% +0.01%
==========================================
Files 44 44
Lines 3387 3385 -2
==========================================
Hits 1138 1138
+ Misses 2152 2150 -2
Partials 97 97
Continue to review full report at Codecov.
|
mmlb
approved these changes
Sep 3, 2021
mmlb
reviewed
Sep 3, 2021
tobert
approved these changes
Sep 3, 2021
I should have started up the tink stack before submitting the PR. I'll get my rig set up before I dig in more (tink-worker and tink need some more otel bits). Ideally we can come up with a functional test that lets us exercise the tink binaries a ilttle without bringing up the whole thing. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix runtime
panic: The unary server interceptor was already set and may not be resetThe grpc server interceptors need to be chained to not cause a runtime panic.
Why is this needed
Fixes: #535
How Has This Been Tested?
make testmake rundocker logs tink_tinkerbell_1- validate the server started up successfully.How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: