Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplified docker-compose: #513

Merged

Conversation

jacobweinstock
Copy link
Member

@jacobweinstock jacobweinstock commented Jun 29, 2021

Description

The previous deploy directory was spinning up more than just tink.
This is a duplicate of what is in the sandbox repo.
This commit adds a basic docker-compose for just tink server and tink cli.
Easy to use make target run will build the binaries first and then up the stack.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #513 (fc0bfda) into master (ab6a1cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   32.70%   32.70%           
=======================================
  Files          44       44           
  Lines        3137     3137           
=======================================
  Hits         1026     1026           
  Misses       2019     2019           
  Partials       92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6a1cc...fc0bfda. Read the comment docs.

@jacobweinstock jacobweinstock force-pushed the update-docker-compose branch 6 times, most recently from 9509c68 to 96f3b63 Compare June 29, 2021 23:01
@jacobweinstock jacobweinstock added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 2, 2021
The previous deploy directory was spinning up
more than just tink. This is a duplicate of what is
in the sandbox repo. This commit adds a basic docker-compose
for just tink server and tink cli. Easy to use make target
`run` will build the binaries first and then up the stack.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock requested a review from mmlb July 2, 2021 15:44
@jacobweinstock jacobweinstock merged commit 4bdd9cb into tinkerbell:master Jul 2, 2021
@jacobweinstock jacobweinstock deleted the update-docker-compose branch July 2, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants