-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix getWorkerID when mac addresses have captalized letters #486
fix getWorkerID when mac addresses have captalized letters #486
Conversation
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=======================================
Coverage 32.70% 32.70%
=======================================
Files 44 44
Lines 3137 3137
=======================================
Hits 1026 1026
Misses 2019 2019
Partials 92 92
Continue to review full report at Codecov.
|
This PR looks great - is there any way we could have a unit test added to ensure that we don't break this again in the future? |
@tstromberg you can extend this case here https://github.com/tinkerbell/tink/blob/master/db/workflow_test.go#L42-L68 and then do a fetch request or workflow get request with a device id that has the characters in lower case. |
Hey @moadqassem, do you mind updating the branch and extend the test as well? It would be great to merge the PR then. |
Signed-off-by: Moath Qasim <[email protected]>
Signed-off-by: Moath Qasim <[email protected]>
dea02b3
to
d502ede
Compare
@gauravgahlot I have added a test case to cover that d502ede cc @tstromberg |
Thank you @moadqassem 🚀 |
Description
Why is this needed
To solve the worker not found errors, when the mac address of the worker is in upper case.
Fixes: #485
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: