Add docker image building targets to Makefile

[mmlb]

Description

Adds make targets to build the docker images.

Why is this needed

Its not very obvious that a user needs to run make crosscompile before they can try to build the docker images (as came up in community slack yesterday).
By having a proper target in the Makefile we might avoid this situation entirely.

How Has This Been Tested?

Ran make images

Checklist:

I have:

• updated the documentation and/or roadmap (if required)
• added unit or e2e tests
• provided instructions on how to upgrade

[codecov]

Codecov Report

Merging #478 (74b32dc) into master (a7ffd35) will not change coverage.
The diff coverage is n/a.

❗ Current head 74b32dc differs from pull request most recent head 81f568e. Consider uploading reports for the commit 81f568e to get more accurate results

@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   32.09%   32.09%           
=======================================
  Files          44       44           
  Lines        3103     3103           
=======================================
  Hits          996      996           
  Misses       2017     2017           
  Partials       90       90           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ffd35...81f568e. Read the comment docs.

[gianarb]

Thanks, when I look at Makefile I am not able to use it. I tried weeks ago but it always requires too much time and I end up writing my own thing... Do you think we can write something as part of the README.md about how to do common tasks like genering all the binaries? single binaries? Does cross compile? docker images and maybe clean the environment? Thanks a lot!! This is mainly a request I personally have, but probably many others have the same issue :D

…

On Thu, Apr 8, 2021 at 4:50 PM Manuel Mendez ***@***.***> wrote: @mmlb <https://github.com/mmlb> requested your review on: #478 <#478> Add docker image building targets to Makefile. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#478 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMOAO33OABYM44264A2F3TTHW7EHANCNFSM42TBXCGA> .

[mmlb]

Thanks, when I look at Makefile I am not able to use it. I tried weeks ago but it always requires too much time and I end up writing my own thing... Do you think we can write something as part of the README.md about how to do common tasks like genering all the binaries? single binaries? Does cross compile? docker images and maybe clean the environment? Thanks a lot!! This is mainly a request I personally have, but probably many others have the same issue :D

I added I think the most relevant bits of that to README.md already. I also reworked the Makefile so only the "important" targets are there and also added make help to it (which is also in the README). I think that should be good enough. Can you take a look at those and see if you want something tweaked/added?

[mmlb]

@gianarb I was going to add the cli,server,worker pseudo targets to the Makefile instead of just as virtual deps but meh go compile is fast enough that I don't think it really matters to just build worker or cli or server, especially when make can do it in parallel.

Also clean is just better off with git clean -fxd imo, but I don't like to do that in make.

[gianarb]

Thanks a lot!