Change package repository and fix build on mac #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is using an old and deprecated package repository. It also fails on Mac. Signed-off-by: Gianluca Arbezzano <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 35.82% 35.82%
=======================================
Files 47 47
Lines 2892 2892
=======================================
Hits 1036 1036
Misses 1763 1763
Partials 93 93 Continue to review full report at Codecov.
|
markjacksonfishing
approved these changes
Mar 11, 2021
mergify bot
added a commit
that referenced
this pull request
Mar 15, 2021
Reverts #459 Not sure why it got merged even if CI/CD is broken @markyjackson-taulia you should no merge that kind of issues and more in general you should leave Mergify doing the actual merge (excluding when a github action workflow changes because it does not merge those PRs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using an old and deprecated package repository. It also fails on
Mac.