Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CreatedAt, UpdatedAt for get workflow and template #444

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Feb 25, 2021

CreatedAt and UpdatedAt were wrong, this commit changed it to RFC.RFC3339

  +--------------------------------------+--------------------------------------+---------------+------------+------------+
  | ID                                   | TEMPLATE ID                          | STATE         | CREATED AT | UPDATED AT |
  +--------------------------------------+--------------------------------------+---------------+------------+------------+
  | 17ff6da3-7780-11eb-a192-ba5d1f2c0c0b | 63b550da-76e7-11eb-a192-ba5d1f2c0c0b | STATE_PENDING | 0xa71f90   | 0xa71f90   |
  +--------------------------------------+--------------------------------------+---------------+------------+------------+

Signed-off-by: Gianluca Arbezzano [email protected]

@gianarb gianarb added area/tink-cli ready-to-merge Signal to Mergify to merge the PR. labels Feb 25, 2021
@gianarb gianarb requested a review from mmlb February 25, 2021 16:39
CreatedAt and UpdatedAt was wrong, this commit changed it to RFC.RFC3339

  +--------------------------------------+--------------------------------------+---------------+------------+------------+
  | ID                                   | TEMPLATE ID                          | STATE         | CREATED AT | UPDATED AT |
  +--------------------------------------+--------------------------------------+---------------+------------+------------+
  | 17ff6da3-7780-11eb-a192-ba5d1f2c0c0b | 63b550da-76e7-11eb-a192-ba5d1f2c0c0b | STATE_PENDING | 0xa71f90   | 0xa71f90   |
  +--------------------------------------+--------------------------------------+---------------+------------+------------+

Signed-off-by: Gianluca Arbezzano <[email protected]>
@gianarb gianarb force-pushed the hotfix/get-template-workflow-time branch from 133a49e to 658a8dd Compare February 25, 2021 16:50
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #444 (3c3653f) into master (19ec067) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   35.10%   35.14%   +0.04%     
==========================================
  Files          47       47              
  Lines        2886     2888       +2     
==========================================
+ Hits         1013     1015       +2     
  Misses       1781     1781              
  Partials       92       92              
Impacted Files Coverage Δ
cmd/tink-cli/cmd/template/get.go 45.45% <100.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ec067...658a8dd. Read the comment docs.

@gianarb gianarb removed the request for review from mmlb March 2, 2021 12:03
@mergify mergify bot merged commit b4aa3b5 into master Mar 2, 2021
@mergify mergify bot deleted the hotfix/get-template-workflow-time branch March 2, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tink-cli ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants