Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tink-client gRPC flags for get and delete command #441

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Feb 25, 2021

Description

Playing with the CLI with JWB we noticed that flags related to
tink-client was not properly added to the get and delete command.

This commit fixes the issue.

Why is this needed

I have added the capability to convert gRPC connection options to flags, but they were not attached to the get and delete command in the right way

Playing with the CLI with JWB we noticed that flags related to
tink-client was not properly added to the get and delete command.

This commit fixes the issue.
@gianarb gianarb added area/tink-cli ready-to-merge Signal to Mergify to merge the PR. labels Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #441 (05fc2ce) into master (a69c792) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   34.82%   35.10%   +0.27%     
==========================================
  Files          47       47              
  Lines        2886     2886              
==========================================
+ Hits         1005     1013       +8     
+ Misses       1789     1781       -8     
  Partials       92       92              
Impacted Files Coverage Δ
cmd/tink-cli/cmd/delete/delete.go 61.53% <100.00%> (+10.25%) ⬆️
cmd/tink-cli/cmd/get/get.go 67.18% <100.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a69c792...05fc2ce. Read the comment docs.

@mmlb mmlb removed the request for review from splaspood February 25, 2021 15:52
@mergify mergify bot merged commit 19ec067 into master Feb 25, 2021
@mergify mergify bot deleted the hotfix/cli-append-grpc-flags branch February 25, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tink-cli ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants