Reimplemented a common delete tink-cli command #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
added
kind/feature
gianarb
suggested changes
Feb 4, 2021
cmd/tink-cli/cmd/delete/delete.go
Outdated
| const longDescr = `Deletes one or many resources and prints the status of | ||
| the deleted resource.` | ||
|
|
||
| const exampleDescr = `# Delete template resource(s) |
There was a problem hiding this comment.
Here you should add a reference to deleting more than one ID.
tink hardware delete [id1] [id2][id3]
You can place an example of the output as well.
As part of the long description you can add an explanation about the output format and how you can pipe it with other commands like awk.
gianarb
suggested changes
Feb 8, 2021
cmd/tink-cli/cmd/delete/delete.go
Outdated
| _, err := opt.DeleteByID(cmd.Context(), opt.fullClient, requestedID) | ||
| if err != nil { | ||
| if s, ok := status.FromError(err); ok && s.Code() == codes.NotFound { | ||
| fmt.Printf("Error\t%s\tnot found\n", requestedID) |
There was a problem hiding this comment.
You have to print to stderr cmd.Stderr
cmd/tink-cli/cmd/delete/delete.go
Outdated
| return err | ||
| } | ||
| } | ||
| fmt.Printf("Deleted\t%s\n", requestedID) |
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 34.34% 34.71% +0.37%
==========================================
Files 46 47 +1
Lines 2865 2892 +27
==========================================
+ Hits 984 1004 +20
- Misses 1794 1796 +2
- Partials 87 92 +5
Continue to review full report at Codecov.
|
gauravgahlot
force-pushed
the
new-delete
branch
from
89aff84
to
5621f84
Compare
gianarb
approved these changes
Feb 9, 2021
|
Awesome work!!! Thanks |
gianarb
suggested changes
Feb 9, 2021
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
force-pushed
the
new-delete
branch
from
5621f84
to
86d5f24
Compare
gianarb
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why is this needed
Fixes: #425
How Has This Been Tested?
Checklist:
I have: