-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ISO mounting to Workflow boot options #1008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
added
the
do-not-merge
Signal to Mergify to block merging of the PR.
label
Oct 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
+ Coverage 30.06% 30.86% +0.80%
==========================================
Files 71 75 +4
Lines 3739 3923 +184
==========================================
+ Hits 1124 1211 +87
- Misses 2539 2617 +78
- Partials 76 95 +19 ☔ View full report in Codecov by Sentry. |
jacobweinstock
force-pushed
the
iso-mounting
branch
2 times, most recently
from
October 11, 2024 19:10
68ff0e4
to
9efd4d8
Compare
These updates allow for ISO mounting as a boot option. Signed-off-by: Jacob Weinstock <[email protected]>
Use STATE_PREPARING and STATE_POST. This allows us to run operations in a specific order in the state flow. Refactor toggling Hardware allowPXE to be more understandable. Fix deleteExisting. It wasn't deleting existing jobs correctly. Instead of doing a static requeue of 5 seconds, use an exponential backoff. All backoff durations are less than 10seconds. Move condition setting into toggleHardware for consistentcy with the handleJob. Make job.bmc names unique per job type (netboot, iso, etc). Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
handleJob no longer deals with setting bootOption status, just conditions. Signed-off-by: Jacob Weinstock <[email protected]>
And to help with understanding code paths taken. This is very helpful as we have to create an idempotent Reconcile function. Signed-off-by: Jacob Weinstock <[email protected]>
Otel was working well, but it was heavy and required a otel specific log collector. The journal is a lot lighter weight. Journal entries are collected during a reconcile and logged once at the end. As this produces a good sized log line per reconcile, debug logging was added so that this is opt in only. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
This makes it so that we don't make get calls as much to the kube api server. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
iso-mounting
branch
from
October 14, 2024 21:49
addc5fa
to
8997356
Compare
jacobweinstock
added
kind/feature
Categorizes issue or PR as related to a new feature.
and removed
do-not-merge
Signal to Mergify to block merging of the PR.
labels
Oct 14, 2024
jacobweinstock
changed the title
[WIP] Add ISO mounting to Workflow boot options
Add ISO mounting to Workflow boot options
Oct 14, 2024
jacobweinstock
added
the
breaking-change
Denotes a PR that introduces potentially breaking changes that require user action.
label
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Denotes a PR that introduces potentially breaking changes that require user action.
kind/feature
Categorizes issue or PR as related to a new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ISO mounting capabilities to Workflow (spec) boot options. This is similar to the netboot option but with a virtual media mount and CDROM as the next boot device. This refactors the Workflow spec to be able to handle both network boot and iso booting.
Current Workflow spec example:
New Workflow spec example for network booting a machine:
New Workflow spec example for ISO booting a machine:
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Upgrade:
Checklist:
I have: