Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls Dockerfile: Move from alpine base #86

Closed

Conversation

surajssd
Copy link

@surajssd surajssd commented Jun 9, 2021

Description

This commit changes the deploy/tls Dockerfile to move from alpine
based image to a fedora based image because The cfssl package was
removed from the alpine package repositories

Why is this needed

Currently one cannot build image due to unavailability of the package.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This commit changes the `deploy/tls` Dockerfile to move from `alpine`
based image to a `fedora` based image because The `cfssl` package was
removed from the `alpine` package repositories

Signed-off-by: Suraj Deshmukh <[email protected]>
Copy link

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the package has not been removed, but disabled: https://gitlab.alpinelinux.org/alpine/aports/-/commit/87380093c842e135ad4babaaca855f7abb2822cd

You could also build the package as part of Docker image building for less intrusive alternative:

FROM alpine:3.11 as cfssl

RUN apk add alpine-sdk gnupg git
RUN addgroup adm abuild

COPY --chown=adm:adm APKBUILD /usr/src/cfssl/

WORKDIR /usr/src/cfssl/

RUN mkdir /var/adm/ && chown adm: /var/adm
USER adm

RUN abuild-keygen -a -i
RUN abuild -r

FROM alpine:3.11

COPY --from=cfssl /var/adm/packages/src/x86_64/cfssl-1.5.0-r1.apk ./
RUN apk add --allow-untrusted ./cfssl-1.5.0-r1.apk

@jacobweinstock
Copy link
Member

Hey @surajssd, #90 just landed and has changed the sandbox significantly. Would you mind having a look at the changes and confirm if this change is still something you'd like to see?

@invidian
Copy link

The packages has been re-enabled, so I guess this is no longer needed: https://gitlab.alpinelinux.org/alpine/aports/-/commit/91367d5d1c5664351d1391f2c28acdab23c92268.

@jacobweinstock
Copy link
Member

The packages has been re-enabled, so I guess this is no longer needed: https://gitlab.alpinelinux.org/alpine/aports/-/commit/91367d5d1c5664351d1391f2c28acdab23c92268.

Thanks, I will close this out!

@surajssd surajssd deleted the use-different-base-image branch September 8, 2021 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants