add current_versions.sh file to the terraform provisioner #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moath Qasim <[email protected]> Signed-off-by: Moath Qasim <[email protected]>
gauravgahlot
approved these changes
Mar 4, 2021
7 tasks
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
) ## Description Mounting the `current_versions.sh` file to the target provisioner when installing TinkerBell on Equinix using terraform <!--- Please describe what this PR is going to change --> ## Why is this needed Because the `generate-envrc.sh` will fail and no TinkerBell env will be created. <!--- Link to issue you have raised --> Fixes: tinkerbell#60 ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> Simply ran the provisioner on Equinix and the env file was created with all the needed info. ## How are existing users impacted? What migration steps/scripts do we need? None <!--- Fixes a bug, unblocks installation, removes a component of the stack etc --> <!--- Requires a DB migration script, etc. --> ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mounting the
current_versions.shfile to the target provisioner when installing TinkerBell on Equinix using terraformWhy is this needed
Because the
generate-envrc.shwill fail and no TinkerBell env will be created.Fixes: #60
How Has This Been Tested?
Simply ran the provisioner on Equinix and the env file was created with all the needed info.
How are existing users impacted? What migration steps/scripts do we need?
None
Checklist:
I have: