Use same IP address for both boots and nginx #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thank you for this work, can you rebase, please? Thanks |
mrchrd
force-pushed
the
single-ip-address
branch
from
506745f to
f115b77
Compare
|
Done |
|
Ops, I am sorry |
|
I am not sure how this will impact users that are running Nginx and I am not sure if we have to mark it as breaking change or not. I will have a look tomorrow 👍 |
Signed-off-by: Michael Richard <[email protected]>
mrchrd
force-pushed
the
single-ip-address
branch
from
f115b77 to
c7b8426
Compare
|
Now it's fixed! |
|
It's probably fair to consider it as a breaking change, even though it won't break anything in a majority of cases. Upgrading will fail if:
|
gianarb
added
breaking-change
gianarb
added
the
ci-check/vagrant-setup
gianarb
reviewed
Jan 27, 2021
gianarb
approved these changes
Jan 27, 2021
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
Signed-off-by: Michael Richard <[email protected]> ## Description This configures NGINX to listen on port 8080 and lets go the need to configure a second IP address on the host dedicated to NGINX. ## Why is this needed Setting up a second IP address to host NGINX on the same host is not always easy, especially when running tinkerbell on network devices like switches. The second IP address adds a useless level of complexity. In the future, all the code required to identify the host operating system and configure the IP address could even be removed and left as a prerequisite, since the host is likely to have an IP address already configured. ## How Has This Been Tested? The untouched vagrant_test.go test ran sucessfully. ## How are existing users impacted? What migration steps/scripts do we need? Simply re-applying the docker-compose.yml should be sufficient (untested). Additional firewall rules to allow traffic on port 8080 could be required depending on user's network configuration. ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Richard [email protected]
Description
This configures NGINX to listen on port 8080 and lets go the need to configure a second IP address on the host dedicated to NGINX.
Why is this needed
Setting up a second IP address to host NGINX on the same host is not always easy, especially when running tinkerbell on network devices like switches. The second IP address adds a useless level of complexity. In the future, all the code required to identify the host operating system and configure the IP address could even be removed and left as a prerequisite, since the host is likely to have an IP address already configured.
How Has This Been Tested?
The untouched vagrant_test.go test ran sucessfully.
How are existing users impacted? What migration steps/scripts do we need?
Simply re-applying the docker-compose.yml should be sufficient (untested).
Additional firewall rules to allow traffic on port 8080 could be required depending on user's network configuration.
Checklist:
I have: