Update component image versions to latest #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detiber
commented
Oct 1, 2021
Comment on lines
+23
to
+33
| variable "use_ssh_agent" { | ||
| type = bool | ||
| description = "Use ssh agent to connect to provisioner machine" | ||
| default = false | ||
| } | ||
|
|
||
| variable "ssh_private_key" { | ||
| type = string | ||
| description = "ssh private key file to use" | ||
| default = "~/.ssh/id_rsa" | ||
| } |
There was a problem hiding this comment.
Previously if a user had a password protected ssh key, provisioning would fail.
This allows users to either override the private key file used, or choose to use an ssh agent to handle authentication.
Comment on lines
+19
to
+22
| config.vm.provider :libvirt do |libvirt| | ||
| libvirt.qemu_use_session = false | ||
| end | ||
|
|
There was a problem hiding this comment.
Previously, if a user tries to stand up the vagrant environment in libvirt it would fail because the default for using user sessions does not allow the creation of a bridge device, which is needed by our networking configuration.
detiber
changed the title
jacobweinstock
approved these changes
Oct 4, 2021
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
Update component image versions to latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates tink, boots, and hegel images to the latest published images (as of Oct 1, 2021)
Why is this needed
Prepare sandbox for an updated release
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
No impact to existing users as far as I was able to tell through my manual testing described above.