-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Compose: "host" network_mode is incompatible with port_bindings #53
Labels
kind/bug
Categorizes issue or PR as related to a bug.
triage/duplicate
Indicates an issue is a duplicate of other open issue.
Comments
Hello!! Thank you for reporting this. It is a duplicate of #53 if you want to help with that, please raise a PR!! we need a fix for that! |
jmarhee
added a commit
to jmarhee/sandbox
that referenced
this issue
Feb 17, 2021
…for boots container definition
3 tasks
jmarhee
added a commit
to jmarhee/sandbox
that referenced
this issue
Feb 17, 2021
…for boots container definition Signed-off-by: Joseph D. Marhee <[email protected]>
mergify bot
added a commit
that referenced
this issue
Feb 18, 2021
#56) … container definition ## Description Resolves #53 ## Why is this needed This conflict causes container creation to fail. Fixes: # ## How Has This Been Tested? I ran the setup and was able to run a workflow and deployment without issue. ## How are existing users impacted? What migration steps/scripts do we need? No impact. ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
What is the solution to this error? I'm also facing the same issue! |
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this issue
Sep 7, 2024
…for boots container definition Signed-off-by: Joseph D. Marhee <[email protected]>
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this issue
Sep 7, 2024
…for boots… (tinkerbell#56) … container definition ## Description Resolves tinkerbell#53 ## Why is this needed This conflict causes container creation to fail. Fixes: # ## How Has This Been Tested? I ran the setup and was able to run a workflow and deployment without issue. ## How are existing users impacted? What migration steps/scripts do we need? No impact. ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Categorizes issue or PR as related to a bug.
triage/duplicate
Indicates an issue is a duplicate of other open issue.
The following lines are in conflict:
https://github.com/tinkerbell/sandbox/blob/58937939c36239e9fb3fb03b5e744f7d0249a9c4/deploy/docker-compose.yml#L117
and
https://github.com/tinkerbell/sandbox/blob/58937939c36239e9fb3fb03b5e744f7d0249a9c4/deploy/docker-compose.yml#L144-L147
Resulting in:
From my reading of this container configuration, it seems like the
network_mode: host
line would be preferable to be removed. It seems to work either way (I tried this using both configurations and was able to complete a provisioning), but not totally sure what the prefered resolution might be if there are implications to either that I'm not considering. Thanks!The text was updated successfully, but these errors were encountered: