Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds retry instead of immediate failure #94

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

ScottGarman
Copy link
Contributor

Description

Instead of immediate failure, we now have a retry mechanism in the event DHCP is slow

Why is this needed

Instant failure happens if the network takes a little bit of time to come up.. this adds a retry and sleep etc.

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

tink-docker/main.go Outdated Show resolved Hide resolved
Copy link

@stephen-fox stephen-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed the HTTP GET timeout as a team, and decided that the caller can deal with it because Go has an awesome concurrency model.

@ScottGarman ScottGarman merged commit 8752d18 into tinkerbell:main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants