Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the right LinuxKit version #6

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Jan 13, 2021

Probably there is a better way but this one works. Now Nix installs the
right version of LinuxKit (v0.8 the one it installed originally does not
support build -docker flag)

Probably there is a better way but this one works. Now Nix installs the
right version of LinuxKit (v0.8 the one it installed originally does not
support build -docker flag)
@deitch
Copy link

deitch commented Jan 13, 2021

Actually, v0.8 doesn't need --docker flag, because it only uses docker. That later commit uses direct communication with a registry, a local cache, and expanding images directly. --docker is for if you are building a package locally and want to use that image instead of something from the registry (because yours is more up to date, or you don't have the image in the registry).

@gianarb
Copy link
Contributor Author

gianarb commented Jan 13, 2021

@deitch with the current version v0.8 the --docker flag is not available yet. I need that flag as you said because we rely on locally built images. Does it make sense?

@deitch
Copy link

deitch commented Jan 13, 2021

Sorry, I wasn't making it very clear.

  • Prior to commit ec80e6cf07e8fd1d1744ebb29afe72d05fa65575, it always used the local docker cache. Every image that it pulled from a registry to build a linuxkit image was via docker pull, every lay out of a filesystem was via docker create and then docker export. It always used local docker (hence, you didn't need --docker; that was precisely how it worked). This includes v0.8.
  • Beginning with commit ec80e6cf07e8fd1d1744ebb29afe72d05fa65575, it doesn't use docker at all, pulling everything from registry to a local cache, no need for a docker daemon. But if you want to use locally built images, then you need --docker.

If you are using v0.8 (pre-ec80e6cf07e8fd1d1744ebb29afe72d05fa65575), then you don't need the --docker flag, as that is how it operates.

@gianarb
Copy link
Contributor Author

gianarb commented Jan 13, 2021

I see, well we are building from the master branch 👍 in this way we are already up to speed I suppose but now I know what's happening! Thanks

@thebsdbox thebsdbox added AWESOMENESS kind/feature Categorizes issue or PR as related to a new feature. labels Jan 13, 2021
@gianarb gianarb merged commit 46d75b5 into master Jan 13, 2021
@gianarb gianarb deleted the chore/nix-build-linuxkit branch January 26, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWESOMENESS kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants