Fix documentation #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a work in progress |
|
Can you move it to draft pr status? Also, thank you so much for this! This is what I love about community |
|
Well.. it can be merged as is. Was waiting to see if there are more changes. |
|
Thank you for your contribution @ghoneycutt you have to sign your commit as explained here: https://github.com/tinkerbell/hook/runs/2232986258 In this way the DCO status will succeed |
|
Dont we publish hook to an s3 bucket? we still want to give people the option of having something pre-built. |
|
The CI/CD system that does that is a pile of sadness and it doesn't to work
since we moved the repo from my account to here
David made an s3 bucket available for us and I think it will get fixed when
this work will be over with multi arch support
#37
…On Wed, Mar 31, 2021 at 9:42 AM Daniel Finneran ***@***.***> wrote:
Dont we publish hook to an s3 bucket? we still want to give people the
option of having something pre-built.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#46 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMOAO3M2UV5TJFFXKTQQ6LTGLG4PANCNFSM42DLNIAA>
.
|
Signed-off-by: Garrett Honeycutt <[email protected]>
ghoneycutt
force-pushed
the
fix_documentation
branch
from
d9ae4dd
to
72aa668
Compare
|
This is ready for merge |
detiber
approved these changes
Mar 31, 2021
markjacksonfishing
approved these changes
Mar 31, 2021
mmlb
pushed a commit
to mmlb/tinkerbell-hook
that referenced
this pull request
Jul 19, 2021
Add action build as validation step in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Going through install process and fixing docs as I go
Why is this needed
Because the documentation does not work