Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the hook kernel config, and fixes makefile #42

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Updates the hook kernel config, and fixes makefile #42

merged 1 commit into from
Mar 18, 2021

Conversation

thebsdbox
Copy link
Contributor

Description

This does two things (apologies, but one needed fixing for the other):

  • Adds a local build to the Makefile, we shouldn't need to always push a kernel kconfig to a registry to build a local kernel
  • Updates the readme to reference the correctly tagged kconfig kernel and displays usage of local build.
  • Adds intel GFX support

Why is this needed

Currently an intel Nuc / Gigabyte brix will hang on boot

Fixes: #

#38

How Has This Been Tested?

Ran locally on a nuc

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@thebsdbox thebsdbox added AWESOMENESS kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 12, 2021
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Mar 12, 2021
detiber
detiber approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm

@mergify mergify bot merged commit a479f53 into tinkerbell:main Mar 18, 2021
mmlb pushed a commit to mmlb/tinkerbell-hook that referenced this pull request Jul 19, 2021
Merge pull request tinkerbell#42 from tinkerbell/fix/get-version-from…
15dab87 
…-manifest

During build time the version should be read from the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianarb gianarb gianarb approved these changes

@detiber detiber detiber approved these changes

Assignees
No one assigned
Labels
AWESOMENESS kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebsdbox @detiber @gianarb