-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch of fixes and enhancements - early january'2025 #257
Merged
mergify
merged 12 commits into
tinkerbell:main
from
rpardini:fixes-batch-early-jan-2025
Jan 13, 2025
Merged
batch of fixes and enhancements - early january'2025 #257
mergify
merged 12 commits into
tinkerbell:main
from
rpardini:fixes-batch-early-jan-2025
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00ab717
to
3853872
Compare
- for consistent bash formatting - include an .editorconfig for IDE's Signed-off-by: Ricardo Pardini <[email protected]>
Signed-off-by: Ricardo Pardini <[email protected]>
Signed-off-by: Ricardo Pardini <[email protected]>
- if on macOS+brew: - detects missing deps and installs them with brew - exports PATH with brew-based GNU versions first - coreutils, gnu-sed and gnu-tar included Signed-off-by: Ricardo Pardini <[email protected]>
- to squash recent BuildKit warnings Signed-off-by: Ricardo Pardini <[email protected]>
- can help with some edge cases Signed-off-by: Ricardo Pardini <[email protected]>
- this only affects Armbian kernel flavours - avoids pulling if found in local cache Signed-off-by: Ricardo Pardini <[email protected]>
- since we now use the local tag Signed-off-by: Ricardo Pardini <[email protected]>
- building the Armbian kernels would produce different hashes depending on the arch of the host - moving the affected code into the Dockerfile would lead to escaping pain; instead implement a docker.sh helper - in practice, all code in the Dockerfile is hashed, but the arch decision is now therein and hash won't change - also, allows for reuse, which is bound to come later Signed-off-by: Ricardo Pardini <[email protected]>
…text` - Some Docker-in-VM solutions (like Docker Desktop, colima, etc) set a non-default docker context pointing to the correct socket - Seems LinuxKit fumbles detecting this and ends up silently failing all local-Docker-daemon cache hits - that is fine for CI, where all images are (beforehand) pushed to the registry (and thus LK ends up pulling from remote), but not during local development - reported to upstream LinuxKit: linuxkit/linuxkit#4092 Signed-off-by: Ricardo Pardini <[email protected]>
…anifest - our kernel builds are done in arch-independent Dockerfiles - but those get the build-host's architecture, despite the contents being correct - when locally developing on a kernel that is != host-arch - those get the host-arch in the image - but LinuxKit refuses to use it due to arch mismatch - (when pushed to a registry, the arch info is discarded, and LK is ok with that) - thus - introduce `ensure_docker_image_architecture(imagetag, arch)` - which just hacks at manifests via a docker save/docker load - call it from both default and armbian kernel builds Signed-off-by: Ricardo Pardini <[email protected]>
- enough spam already, thanks Signed-off-by: Ricardo Pardini <[email protected]>
3853872
to
4356a41
Compare
jacobweinstock
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: implement
shellfmt
(andlint
which does both shellcheck/fmt)gha: switch to
lint
(which does bothshellcheck
andshellfmt
)linuxkit: bump 1.5.2 -> 1.5.3
build: implement build-host dependency handling for macOS+brew
build: Dockerfile: fix FROM xx AS casing
build: pass
--verbose 2
to linuxkit ifDEBUG=yes
build: refactor skopeo pull and list-tags functions
build: use skopeo
v1.17.0
instead of latestbuild: armbian: kernel: refactor Dockerfile with helper
build: docker: detect & export
DOCKER_HOST
from currentdocker context
docker context
(colima, Docker Desktop) and fails--docker
lookups silently linuxkit/linuxkit#4092build: kernel: force target arch on cross-built kernel docker image manifest
ensure_docker_image_architecture(imagetag, arch)
build: docker: avoid Docker Inc's "What's next" hints
Signed-off-by: Ricardo Pardini [email protected]