Add ISO builds to CI: #245
Merged
+20
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds ISO builds to CI and releases. Remove deprecated CI directory. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
add-iso-to-releases
branch
from
8084798
to
48ec920
Compare
This allows each flavor of HookOS to be differentiated. This is needed in CI and for GitHub artifacts in the releases. Signed-off-by: Jacob Weinstock <[email protected]>
rpardini
reviewed
Nov 13, 2024
| patterns: "*.tar.gz" | ||
| patterns: | | ||
| "*.tar.gz" | ||
| "*.iso" |
There was a problem hiding this comment.
@jacobweinstock I think you've unwanted quotes here; this will cause checksum to be empty, I think.
There was a problem hiding this comment.
Ah thank you! i've been looking for why the checksum wasnt being created!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds ISO builds to CI and releases. Remove deprecated CI directory.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: