Add emmc support #23
Merged
Add emmc support #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still working on testing this build |
Arguably the most import region! Thanks for the pr (once tested) |
|
Looks like it is still missing something, will do some more digging... |
|
Ok, updated and tested and successfully ran a workflow with these kernel changes. It wasn't clear to me how the kernel is picked up through the build pipeline, though. |
|
Great! Yeah it is not clear because I do it manually right now. We didn't build a good story yet @thebsdbox |
mmlb
pushed a commit
to mmlb/tinkerbell-hook
that referenced
this pull request
Jul 16, 2021
## Description ``` time="2021-03-04T13:18:50Z" level=info msg="Successfully written [%s] to [%s]http://192.168.1.2/focal-server-cloudimg-amd64.raw/dev/sdb" ``` Wrong function is being called here `info` -> `infof` <!--- Please describe what this PR is going to change --> ## Why is this needed The success meeting is mis-formatted. <!--- Link to issue you have raised --> Fixes: # ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## How are existing users impacted? What migration steps/scripts do we need? <!--- Fixes a bug, unblocks installation, removes a component of the stack etc --> <!--- Requires a DB migration script, etc. --> ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the support needed for us-east-detiber