Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework image naming in ci #210

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

jacobweinstock
Copy link
Member

@jacobweinstock jacobweinstock commented May 1, 2024

Description

rework image naming.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

The service containers we build shouldnt
use arch in the tags. This way the same tag
will have mulitple archs at the registry layer.

Signed-off-by: Jacob Weinstock <[email protected]>
This allows a single repo with different tags

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock changed the title Fix ci rework image naming in ci May 1, 2024
@jacobweinstock jacobweinstock merged commit acac456 into tinkerbell:main May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant