Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apk repository for kexec-tools #192

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

sirhopcount
Copy link
Contributor

Description

kexec-tools has been promoted from edge/testing to edge/community. This PR updates the repository in the hook-docker Dockerfile.

For reference: https://git.alpinelinux.org/aports/commit/community/kexec-tools/APKBUILD?id=eccd9de1410cd384891105da4bedb05b7db44744

Why is this needed

Builds will fail because the kexec-package cannot be installed:

#7 2.121 ERROR: unable to select packages:
#7 2.121   kexec-tools (no such package):
#7 2.121     required by: world[kexec-tools]
------
Dockerfile:8
--------------------
   6 |     FROM docker:24.0.4-dind
   7 |     RUN echo "http://dl-cdn.alpinelinux.org/alpine/edge/testing" >> /etc/apk/repositories
   8 | >>> RUN apk update; apk add kexec-tools
   9 |     COPY --from=dev /hook-docker .
  10 |     ENTRYPOINT ["/hook-docker"]
--------------------
error: failed to solve: process "/bin/sh -c apk update; apk add kexec-tools" did not complete successfully: exit code: 1
make: *** [rules.mk:81: out/sha-4b355bc/hook-docker-amd64] Error 1

How Has This Been Tested?

I successfully ran make containers:

#15 importing to docker                                                                                                       
#15 DONE 0.7s                                                                                                                 
                               
#14 exporting to docker image format
#14 sending tarball 1.8s done                                                                                                 
#14 DONE 3.2s

How are existing users impacted? What migration steps/scripts do we need?

No and None

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

kexec-tools has been promoted from edge/testing to edge/community

Signed-off-by: sirhopcount <[email protected]>
Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sirhopcount

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Nov 21, 2023
@mergify mergify bot merged commit 7887a91 into tinkerbell:main Nov 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants