Make linuxkit Hook services resilient so that the getty always comes up: #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook-bootkit requires a network connection to pull down the tink-worker image. The previous solution was to make sure networking was up and running via a DHCP client in the linuxkit "onboot" section. This meant that any issues with the DHCP onboot container would cause the getty, and all services, to never start. This made troubleshooting nearly impossible. This PR makes Hook-bootkit (and hook-docker) retry all failures. This allows us to remove the DHCP "onboot" container. This should allow the getty service to always start. Signed-off-by: Jacob Weinstock <[email protected]>
chrisdoherty4
previously approved these changes
Jul 30, 2023
`make run` didn't work with the "tar-kernel-initrd" files produced. Signed-off-by: Jacob Weinstock <[email protected]>
The alpine image (instead of scratch) so that we can run commands inside the container for troubleshooting. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
allows-getty
branch
from
310ed81
to
c32809d
Compare
chrisdoherty4
previously approved these changes
Jul 31, 2023
Signed-off-by: Jacob Weinstock <[email protected]>
Zerolog stack traces weren't providing enough detail and had a indirect dependency on an archived library (pkg/errors). Signed-off-by: Jacob Weinstock <[email protected]>
The docker logs output for the pull image command will be properly structured now. Signed-off-by: Jacob Weinstock <[email protected]>
|
Hey @chrisdoherty4 , thanks for the review. JFYI, this is just a refactor step. There is still much more work to be done. I will follow in the future with more refactoring. |
chrisdoherty4
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hook-bootkit requires a network connection to pull down the tink-worker image. The previous solution was to make sure networking was up and running via a DHCP client in the linuxkit "onboot" section. This meant that any issues with the DHCP onboot container would cause the getty, and all services, to never start. This made troubleshooting nearly impossible.
This PR makes Hook-bootkit (and hook-docker) retry all failures. This allows us to remove the DHCP "onboot" container. This should allow the getty service to always start.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: