Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename noname to tinkie #17

Merged
merged 2 commits into from
Jan 24, 2021
Merged

Rename noname to tinkie #17

merged 2 commits into from
Jan 24, 2021

Conversation

nicklasfrahm
Copy link
Contributor

@nicklasfrahm nicklasfrahm commented Jan 22, 2021 •
edited
Loading

Fixes #15.

There are some things that need to be adjusted before merging this.

  • Set up S3 bucket with the new name
  • Adjust repository path, so references to the repository aren't broken
  • Test if everything works as intended

@nicklasfrahm
Rename noname to tinkie
ea05ddd 
Signed-off-by: Nicklas Framh <[email protected]>
@thebsdbox
Copy link
Contributor

Looks like nonane.yaml will need renaming so that the linuxkit build command doesn't fail.

@thebsdbox
Copy link
Contributor

This is now fixed, the error is with the S3 bucket (@gianarb)

@gianarb
Copy link
Contributor

gianarb commented Jan 24, 2021

yayyyy!!!

@gianarb gianarb merged commit d9b961a into tinkerbell:master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename noname to tinkie
3 participants
@nicklasfrahm @thebsdbox @gianarb