Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused metadata network call #149

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Conversation

jacobweinstock
Copy link
Member

Description

This removes unused code making network calls to Hegel and updates the linter version.

Why is this needed

Fixes: #110

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This is not needed anymore. Tink-Worker does not
need or use the env var `container_uuid`.

Signed-off-by: Jacob Weinstock <[email protected]>
Allows the linter to function properly with Go 1.19, which
is the latest released version and in use by most developers.

Signed-off-by: Jacob Weinstock <[email protected]>
This s3cmd is no longer used in the repo.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Oct 20, 2022
@mergify mergify bot merged commit f0e4f7b into tinkerbell:main Oct 20, 2022
@jacobweinstock jacobweinstock deleted the clean-up branch October 20, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bootkit] purpose of func metaDataQuery and container_uuid
2 participants