ci: Limit the kernel push only to branch pushes #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which means we exclude all tags. This is necessary because according to the docs[1]: > Path filters are not evaluated for pushes of tags. So we need to avoid building for tags. This is fine to do because the kernel isn't versioned by tags but by the contents of the kernel/ tree. I went with `branches: "**"` instead of `tags-ignore: "**"` because inclusion is easier to understand vs exclusion imo. 1: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore Signed-off-by: Manuel Mendez <[email protected]>
mmlb
force-pushed
the
update-kernel-push-for-tags
branch
from
77f3291 to
c43967e
Compare
ScottGarman
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids building the kernel for tag pushes.
Why is this needed
The kernel builds are currently filtering the events that cause the build depending on the path of files changed. The path filter is not evaluated for tag pushes though. This causes the kernel to be re-pushed on tags which is unexpected and confusing. I'd rather avoid confusion in the kernel build/push process if possible.