Publish GitHub Releases #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On both push to main (updates the `latest` release) and tags (creates release for the tag). Publishing on main to the latest release gives us a url we can use for sandbox until a new release is cut or if we want to run sandbox with bleeding edge hook builds. Signed-off-by: Manuel Mendez <[email protected]>
ScottGarman
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Publishes GitHub Releases for both version tags and pushes to main.
Why is this needed
Publishing on main to the latest release gives us a url we can use for sandbox
until a new release is cut if we want to run sandbox with bleeding edge
hook builds.
Publishing on version tags (
v*) removes some friction to creating releases and hopefully opens us up for more frequent releases.How Has This Been Tested?
I simulated many of the scenarios on my fork, see the action runs for it https://github.com/mmlb/tinkerbell-hook/actions.
How are existing users impacted? What migration steps/scripts do we need?
Usable hooks w/o needing to build locally + hopefully more frequent tagged releases.