Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop grpc_cert_url param #134

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Jun 17, 2022

Description

Now that tink never serves /cert we don't need to handle it.

Why is this needed

Cleaning up unused code/tech-debt.

How Has This Been Tested?

Ran a workflow run.

Now that tink never serves /cert we don't need to handle it.

Signed-off-by: Manuel Mendez <[email protected]>
@mmlb mmlb requested a review from ScottGarman June 17, 2022 16:28
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Jun 17, 2022
@mergify mergify bot merged commit 57d1fcd into tinkerbell:main Jun 17, 2022
@mmlb mmlb deleted the drop-grpc-cert-param branch June 17, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants