Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to kernel/ directory require validation check #145

Closed
jacobweinstock opened this issue Oct 12, 2022 · 0 comments · Fixed by #173
Closed

changes to kernel/ directory require validation check #145

jacobweinstock opened this issue Oct 12, 2022 · 0 comments · Fixed by #173

Comments

@jacobweinstock
Copy link
Member

jacobweinstock commented Oct 12, 2022 •
edited
Loading

The validation check is required for all PR's and will not run for changes only in the kernel/ directory. This causes PRs like #144 to not meet the merge criteria and therefore not meet all merge requirements.

Expected Behaviour

A change only in thekernel/ directory is still able to satisfy all PR checks.

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:
@jacobweinstock jacobweinstock mentioned this issue Oct 12, 2022
Merged
3 tasks
This was referenced Jul 7, 2023
Closed
Merged
@mergify mergify bot closed this as completed in #173 Jul 20, 2023
mergify bot added a commit that referenced this issue Jul 20, 2023
@mergify
Run CI jobs for all directories: (#173)
fc8ee64 
## Description


This works around an issue where a change in the `kernel/` directory doesn't trigger the required validation check in GitHub.

## Why is this needed



Fixes: #145 

## How Has This Been Tested?





## How are existing users impacted? What migration steps/scripts do we need?





## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run CI jobs for all directories: jacobweinstock/hook
1 participant
@jacobweinstock