Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disk wipe command #90

Closed
moadqassem opened this issue Sep 15, 2022 · 0 comments · Fixed by #91
Closed

Add disk wipe command #90

moadqassem opened this issue Sep 15, 2022 · 0 comments · Fixed by #91

Comments

@moadqassem
Copy link
Member

Expected Behaviour

At the moment, there are no command, dedicated only for wiping disks without partitioning it all over again. It would be really helpful to have a dedicated command, where user can only wipe disks without any partitioning, using the metadata of the Hardware.

Current Behaviour

Not possible to run disk wiping without partitioning the disks again.

Possible Solution

Extracting the Wipe functionality from the disk partition and use a dedicated command. Here is PR:

Steps to Reproduce (for bugs)

Context

This is very helpful, when the provisioned machine, are gonna be used by some storage specific services or SDS operator, as some of those operator don't use disks that are in a specific status(for example if the disks have partitions, the storage operator would considered this disk being in used by some other software and wouldn't use and utilize it).

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:
@moadqassem moadqassem mentioned this issue Sep 15, 2022
Merged
3 tasks
@mergify mergify bot closed this as completed in #91 Sep 21, 2022
mergify bot added a commit that referenced this issue Sep 21, 2022
@mergify
Extract disk wiping from disk partitioning (#91)
8e1f99f 
## Description
Extracting the Wipe functionality and add it as a dedicated command, where user can only wipe disks without any partitioning, using the metadata of the Hardware. 



## Why is this needed
This is very helpful, when the provisioned machine, is gonna be used by some storage specific services or SDS operator, as some of those operators don't use disks that are in a specific status(for example if the disks have partitions, the storage operator would considered this disk is being used by anther software and wouldn't use and utilize it).


Fixes: #90

## How Has This Been Tested?



It was tested by using this commit and build an image out of it, where this image has been use as a workflow to de provision a machine. 

## How are existing users impacted? What migration steps/scripts do we need?
NA




## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract disk wiping from disk partitioning moadqassem/hub
1 participant
@moadqassem