Bug fix CNN/DM and XSum initialization #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the changes made in PR #16, where a bug related to the
CNNDM
variable insummac/benchmark.py
was identified.Specifically, when the
CNNDM
variable is undefined, lines 44 and 54 can raise aNameError: name 'CNNDM' is not defined
:summac/summac/benchmark.py
Lines 41 to 61 in 9e4f357
The fix proposed by @forrestbao effectively resolve this issu, but during testing I noticed some performance concerns.>
To address this, I propose an alternative fix that leverages class variables. Through this new approach:
SummaCBenchmark
class is created.In addition, the GDrive link for the SummEval dataset provided in lines 271-276 (apparently from the 4/19/2020 update on the
README.md
file of the original repo https://github.com/Yale-LILY/SummEval) is broken.summac/summac/benchmark.py
Lines 271 to 276 in 9e4f357
I replaced it with a valid GCS bucket link that can be found on the
README.md
file of the same repo under the "Human annotations" header (https://storage.googleapis.com/sfr-summarization-repo-research/model_annotations.aligned.jsonl)Changes
NameError
by modified dataset loading in theSummaCBenchmark
class.