Skip to content

Commit

Permalink
Remove deprecated actions (bazel-contrib#3173)
Browse files Browse the repository at this point in the history
We announced that we would remove them in 0.36.0.
  • Loading branch information
fmeum authored and jacqueline.lee committed Jul 19, 2023
1 parent df66cd2 commit 743bc72
Show file tree
Hide file tree
Showing 16 changed files with 9 additions and 801 deletions.
3 changes: 0 additions & 3 deletions go/private/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,8 @@ bzl_library(
"//go/private:platforms",
"//go/private:providers",
"//go/private/actions:archive",
"//go/private/actions:asm",
"//go/private/actions:binary",
"//go/private/actions:compile",
"//go/private/actions:link",
"//go/private/actions:pack",
"//go/private/actions:stdlib",
],
)
Expand Down
33 changes: 0 additions & 33 deletions go/private/actions/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,6 @@ bzl_library(
],
)

bzl_library(
name = "asm",
srcs = ["asm.bzl"],
visibility = ["//go:__subpackages__"],
deps = [
"//go/private:mode",
"//go/private/actions:deprecation",
],
)

bzl_library(
name = "binary",
srcs = ["binary.bzl"],
Expand All @@ -46,16 +36,6 @@ bzl_library(
],
)

bzl_library(
name = "compile",
srcs = ["compile.bzl"],
visibility = ["//go:__subpackages__"],
deps = [
"//go/private:mode",
"//go/private/actions:deprecation",
],
)

bzl_library(
name = "compilepkg",
srcs = ["compilepkg.bzl"],
Expand All @@ -66,12 +46,6 @@ bzl_library(
],
)

bzl_library(
name = "deprecation",
srcs = ["deprecation.bzl"],
visibility = ["//go:__subpackages__"],
)

bzl_library(
name = "link",
srcs = ["link.bzl"],
Expand All @@ -84,13 +58,6 @@ bzl_library(
],
)

bzl_library(
name = "pack",
srcs = ["pack.bzl"],
visibility = ["//go:__subpackages__"],
deps = ["//go/private/actions:deprecation"],
)

bzl_library(
name = "stdlib",
srcs = ["stdlib.bzl"],
Expand Down
60 changes: 0 additions & 60 deletions go/private/actions/asm.bzl

This file was deleted.

99 changes: 0 additions & 99 deletions go/private/actions/compile.bzl

This file was deleted.

15 changes: 0 additions & 15 deletions go/private/actions/deprecation.bzl

This file was deleted.

53 changes: 0 additions & 53 deletions go/private/actions/pack.bzl

This file was deleted.

3 changes: 0 additions & 3 deletions go/private/context.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -518,11 +518,8 @@ def go_context(ctx, attr = None):
cover_format = mode.cover_format,
# Action generators
archive = toolchain.actions.archive,
asm = toolchain.actions.asm,
binary = toolchain.actions.binary,
compile = toolchain.actions.compile,
link = toolchain.actions.link,
pack = toolchain.actions.pack,

# Helpers
args = _new_args, # deprecated
Expand Down
6 changes: 0 additions & 6 deletions go/private/go_toolchain.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,8 @@ Toolchain rules used by go.
load("//go/private:platforms.bzl", "PLATFORMS")
load("//go/private:providers.bzl", "GoSDK")
load("//go/private/actions:archive.bzl", "emit_archive")
load("//go/private/actions:asm.bzl", "emit_asm")
load("//go/private/actions:binary.bzl", "emit_binary")
load("//go/private/actions:compile.bzl", "emit_compile")
load("//go/private/actions:link.bzl", "emit_link")
load("//go/private/actions:pack.bzl", "emit_pack")
load("//go/private/actions:stdlib.bzl", "emit_stdlib")

GO_TOOLCHAIN = "@io_bazel_rules_go//go:toolchain"
Expand All @@ -38,11 +35,8 @@ def _go_toolchain_impl(ctx):
default_goarch = ctx.attr.goarch,
actions = struct(
archive = emit_archive,
asm = emit_asm,
binary = emit_binary,
compile = emit_compile,
link = emit_link,
pack = emit_pack,
stdlib = emit_stdlib,
),
flags = struct(
Expand Down
Loading

0 comments on commit 743bc72

Please sign in to comment.