LPS 205346 1 9 1 #2564
Open
LPS 205346 1 9 1 #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantewang
commented
Jan 10, 2024
dantewang
commented
- LPS-205097 Make sure the guest users are generated before generating UserPersonalSiteGroupModel as the it has a dependeny on the Gues userId in java code
- LPS-205097 Remove left over guest_user.ftl as we just need to generate guest users for the default company
- LPS-205346 Add unit test to do benchmark test for logic locally
- LPS-205346 Add integration test
- LPS-205346 Fix failure when running for the second time. If the password column is "test" after inserting the generated SQL, after the first login (warmup), it will be updated as "{none}test" -- the "{}" indicates the password algorithm.
- LPS-205346 The integration test also suffers from this {none} in password.
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
dantewang
force-pushed
the
LPS-205346-1-9-1
branch
from
77f28a3 to
a2df73f
Compare
…ord column is "test" after inserting the generated SQL, after the first login (warmup), it will be updated as "{none}test" -- the "{}" indicates the password algorithm.
…ise 127.0.0.1 will always go to default company.
… this, otherwise the login will fail at PwdAuthenticator
dantewang
force-pushed
the
LPS-205346-1-9-1
branch
from
a2df73f to
c5294a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.