LPS-172979 | master #2558
Open
LPS-172979 | master #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
@TaiPhamLR what is the status of this PR? Is it going to be merged in order to fix LPS-172979? Thanks in advance for the update! |
TaiPhamLR
force-pushed
the
LPS-172979_master
branch
from
a6c091d to
fd76444
Compare
|
Hi @magjed4289, after 2 PRs: liferay-core-infra#3643, liferay-core-infra#3546, I'm still looking forward to new Tina's comments. She may not pay attention to this PR. I've create new PR liferay-core-infra#3997 for her team - Liferay-core-infra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tinatian,
This PR is for the issue: https://issues.liferay.com/browse/LPS-172979
Previous PR: liferay-core-infra#3643
I'm looking forward to your feedback.
Thanks a lot,
Tai.