Named filters (ie. &foo=1) are always cast as strings in where clause #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwis
added a commit
to CityOfPhiladelphia/soda-carto
that referenced
this pull request
Feb 15, 2017
|
@timwis Checked with "the experts" and this approach should generally be safe. However, before we merge, does this account for cases where |
|
Great point @andrewbt. This definitely didn't accommodate that. Just pushed 2 commits to account for inner quotes, as well as surrounding quotes in named filters. A bit confusing because postgres doesn't accept backslashes to escape quotes; you have to use a quote twice. Hope this is right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?foo=1&bar=testused to result inWHERE foo = 1 AND bar = 'test'.This PR makes it result in
WHERE foo = '1' AND bar = 'test'.closes CityOfPhiladelphia/soda-carto#23