keyContainFix #23
Open
keyContainFix #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
reviewed
Nov 9, 2024
| @@ -14,7 +14,7 @@ pub fn format_fingerprint<S: AsRef<str>>(fingerprint: S) -> String { | |||
| /// Check whether two fingerprints match. | |||
| pub fn fingerprints_equal<S: AsRef<str>, T: AsRef<str>>(a: S, b: T) -> bool { | |||
| !a.as_ref().trim().is_empty() | |||
| && a.as_ref().trim().to_uppercase() == b.as_ref().trim().to_uppercase() | |||
| && a.as_ref().trim().to_uppercase().contains(&b.as_ref().trim().to_uppercase()) | |||
There was a problem hiding this comment.
What do you think, would starts_with work as well?
Because then I expect A0B1C2 # comment to still match A0B1C2.
I'd prefer it to be as strict as possible when we can.
Sorry for my late reply on this.
There was a problem hiding this comment.
wouldn't startwith fail the new gnupg format that start with 0x<ID>.....(also default in gopass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it makes the function names very confusing because now
fn fingerprints_equal means contain
fn fingerprints_contain means search store with...
solves #22
Anyway, doing the search ourselves not using the
gpg search c++ apiis probably right