Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fixed dependency version for GitPython #56

Closed
wants to merge 1 commit into from

Conversation

miffels
Copy link

@miffels miffels commented Aug 2, 2021

Hey,

We've had an issue in our pipeline lately that appears to have been due to a combination of Python 3.7 on the build box and this plugin transitively pulling GitPython v3.1.20. The issue appears to be related to gitpython-developers/GitPython#1095. We were able to resolve the issue by setting the last known working version, which was 3.1.19. It's now fixed for us since we added GitPython to our own project dependencies with that version, but this might help others avoid the issue altogether. Otherwise some sort of FAQ or troubleshooting/setup guide might be helpful where people should set their own reliable version for stable builds.

Cheers!

@timvink
Copy link
Owner

timvink commented Aug 4, 2021

Thanks a lot for digging into this and providing a PR!

There are two choices here: 1) either I fixed dependencies, and on every update re-run the tests and deploy a new version (f.e. using dependabot). 2) I set a minimal version, trust downstream releases and let the user deal with problems should they arise.

I am going for 2), because of maintenance time mainly but also to avoid forcing users into specific versions.

It also turns out that GitPython yanked the faulty release in the meantime:

image

So, I will close this PR. I have opened #57 to make sure I am notified of these kinds of issues earlier however.

@timvink timvink closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants