Fixes an issue where song sort order is 0 when adding to playlist #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This chang ensures that the sort order for a song added to a playlist starts at a minimum value of playlist.songCount. This prevents multiple entries with a sort order of '0' which can cause the true sort order to be lost.
|
Thanks for this MR! Probably more efficient than #118 indeed :) I haven't tested it yet (but I suppose you did, so that's fine for me!) |
|
@daladim I actually haven't tested this 😳 |
|
I've just successfully tested it, I think this can be safely merged into |
This was referenced Apr 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chang ensures that the sort order for a song added to a playlist starts at a minimum value of playlist.songCount. This prevents multiple entries with a sort order of '0' which can cause the true sort order to be lost.