Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Missing file - version.txt #380

Closed
xiaoyaooo opened this issue Jun 8, 2021 · 2 comments · Fixed by #382
Closed

Missing file - version.txt #380

xiaoyaooo opened this issue Jun 8, 2021 · 2 comments · Fixed by #382

Comments

@xiaoyaooo
Copy link

Hi Dear Authors,

I may have found one small and trivial problem in your released source code. As for mac users, they need to run the software using the source code, it would be great if you could fix this.
The problem is as described in the issue title, the file that should store the current version of the code is missing.
There should be a version.txt containing "v1.1.8" under the root directory.

Because either the main.py or the gui.py will call tools.utils.get_current_version() before the program runs, if that file is missing, there will be problem for both CLI and GUI version. The CLI version runs still with an error notice, but the GUI won't open.

And btw, thank you very much for creating this great software! I did get my termin using this weeks ago.

@xiaoyaooo
Copy link
Author

xiaoyaooo commented Jun 8, 2021 via email

@timreibe
Copy link
Owner

timreibe commented Jun 8, 2021

thanks @xiaoyaooo and @stefanogito

timreibe pushed a commit that referenced this issue Jun 8, 2021
* Create version.txt

* Update utils - removed empty lines/comments

* Added output if source files are used.

* Update gui.py
timreibe added a commit that referenced this issue Jun 8, 2021
This reverts commit 9028a25.
timreibe added a commit that referenced this issue Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants