Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade minimum Go version #92

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 16, 2024

Since go1.21, the Go version used inside the go.mod is the minimum Go version and it's a hard requirement.

golangci-lint must support compilation with go1.22 and go1.23.

@ldez
Copy link
Contributor Author

ldez commented Oct 29, 2024

friendly ping @timonwong

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.79%. Comparing base (4e02d5e) to head (590af02).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/checkers/types.go 60.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   98.72%   97.79%   -0.94%     
==========================================
  Files          13       14       +1     
  Lines         470      589     +119     
==========================================
+ Hits          464      576     +112     
- Misses          3       10       +7     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timonwong
Copy link
Owner

@ldez I think I need to create build tags to handle reflect pacakge change since #89, just downgrading go.mod version may not work

@timonwong
Copy link
Owner

I'm working on it

Signed-off-by: Timon Wong <[email protected]>
@timonwong timonwong enabled auto-merge (squash) October 30, 2024 06:13
@timonwong timonwong merged commit 070a2f5 into timonwong:master Oct 30, 2024
5 of 7 checks passed
@ldez ldez deleted the fix/go-version branch October 30, 2024 09:18
@ldez ldez mentioned this pull request Oct 30, 2024
@ldez
Copy link
Contributor Author

ldez commented Oct 30, 2024

@timonwong I created a PR to handle aliases with the official approach: #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants