Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: key value check is special for zap #28

Merged
merged 4 commits into from
Aug 30, 2022
Merged

fix: key value check is special for zap #28

merged 4 commits into from
Aug 30, 2022

Conversation

timonwong
Copy link
Owner

@timonwong timonwong commented Aug 30, 2022 •
edited
Loading

Fixes #27

@timonwong timonwong changed the title Fix: fix key value check for zap Fix: fix key value check for zap (#27) Aug 30, 2022
@timonwong timonwong changed the title Fix: fix key value check for zap (#27) fix: key value check is special for zap (#27) Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022 •
edited
Loading

Codecov Report

Merging #28 (ff455c2) into master (1fd3821) will increase coverage by 1.31%.
The diff coverage is 99.25%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   95.46%   96.78%   +1.31%     
==========================================
  Files           7       10       +3     
  Lines         353      404      +51     
==========================================
+ Hits          337      391      +54     
+ Misses         11        9       -2     
+ Partials        5        4       -1
Impacted Files Coverage Δ
staticrules.go 100.00% <ø> (ø)
loggercheck.go 87.73% <94.73%> (-2.91%) ⬇️
internal/checkers/common.go 100.00% <100.00%> (ø)
internal/checkers/general.go 100.00% <100.00%> (ø)
internal/checkers/zap.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timonwong
Copy link
Owner Author

@ttys3 PTAL

@timonwong timonwong changed the title fix: key value check is special for zap (#27) fix: key value check is special for zap (fix #27) Aug 30, 2022
@timonwong timonwong changed the title fix: key value check is special for zap (fix #27) fix: key value check is special for zap Aug 30, 2022
timonwong and others added 2 commits August 30, 2022 14:03
@timonwong
add comments
381fd45 
Signed-off-by: Timon Wong <[email protected]>
@ttys3
test: make zap Field test cover both default sugared and custom sugar…
c387052 
…ed, add `With` test case with Field
@timonwong timonwong requested a review from ttys3 August 30, 2022 06:36
@ttys3
Copy link
Collaborator

ttys3 commented Aug 30, 2022 •
edited
Loading

LGTM

I got the zap tests slightly improved and adjust a comment position

@timonwong timonwong enabled auto-merge (squash) August 30, 2022 06:43
@timonwong timonwong merged commit 5b1d33b into master Aug 30, 2022
@timonwong timonwong deleted the special-zap branch August 30, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttys3 ttys3 ttys3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable zap by default
2 participants
@timonwong @ttys3