Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gitlab headers to avoid next page #378

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Use Gitlab headers to avoid next page #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b9b63ba
Fix skip_confirmation
morganseznec Oct 23, 2017
7822f43
Fixed create user test
Dec 15, 2017
169a4ea
Add external property to GitlabUser model
Feb 19, 2018
f8d94d6
Add methods to create/update group
Feb 19, 2018
f263c38
Fix conflicts
Feb 19, 2018
4392d4e
Merge remote-tracking branch 'upstream/master'
Jun 18, 2018
b07de6b
Merge remote-tracking branch 'upstream/master'
Jul 16, 2020
390d036
Update repo
Jul 16, 2020
b4c8776
Update repo
Jul 16, 2020
d883f28
Update repo
Jul 16, 2020
1da2d99
Use Gitlab headers to avoid next page
Jul 16, 2020
0191b33
Update GitlabHTTPRequestor.java
Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.5.3</version>
<version>2.9.10</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
Expand Down Expand Up @@ -155,7 +155,7 @@
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
<version>2.5.1</version>
<version>2.9.10</version>
</dependency>

</dependencies>
Expand Down
12 changes: 11 additions & 1 deletion src/main/java/org/gitlab/api/http/GitlabHTTPRequestor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,21 @@ private void fetch() {
}

try {

HttpURLConnection connection = setupConnection(url);
String totalPages = connection.getHeaderField("X-Total-Pages");
String currentPage = connection.getHeaderField("X-Page");

try {
next = parse(connection, type, null);
assert next != null;
findNextUrl();

if(totalPages != null && totalPages.equals(currentPage)) {
url = null;
} else {
findNextUrl();
}

} catch (IOException e) {
handleAPIError(e, connection);
}
Expand Down