Prepare for React 19 #374
Closed
Prepare for React 19 #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
What does the Vercel failure mean? Did I break something? |
|
@timolins Would you know how I can troubleshoot the Vercel failure? |
|
@timolins Any comments on this? |
|
I came here to open exactly this PR. Now, I wonder whether I need to switch the toast library... |
|
@frontendphil I already switched to toastify, which is pretty similar and actively maintained. I'll leave this PR open just in case the project comes back to life. |
|
@timolins can you pelase switch to github actions to let contributors see the issue? This could be good enough I think: https://daiyi.co/blog/pr-previews-for-github-pages/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global
JSXtype is deprecated in React 18.3 and removed in React 19 RC. This PR changes the code to use the supportedReact.JSXsyntax instead. It also changes fromJSX.Elementto the supportedReact.ReactElement.