refactor: apply best practices #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some suggestions could not be made:
- src/main/java/io/github/timoa/lombok/ConvertGetter.java
- lines 125-127
- src/main/java/io/github/timoa/lombok/ConvertNoArgsConstructor.java
- lines 76-78
- src/main/java/io/github/timoa/lombok/ConvertSetter.java
- lines 127-129
- src/main/java/io/github/timoa/lombok/LombokUtils.java
- lines 65-66
- src/main/java/io/github/timoa/lombok/SummarizeData.java
- lines 99-103
- src/main/java/io/github/timoa/lombok/SummarizeGetter.java
- lines 106-107
- lines 120-124
- src/main/java/io/github/timoa/lombok/SummarizeSetter.java
- lines 96-97
- lines 110-111
- lines 124-129
- src/main/java/io/github/timoa/misc/UseRanges.java
- lines 43-50
- lines 84-91
- lines 125-132
- lines 166-173
- lines 207-214
- lines 248-255
- lines 289-296
- lines 330-337
There was a problem hiding this comment.
Some suggestions could not be made:
- src/main/java/io/github/timoa/lombok/ConvertGetter.java
- lines 125-127
- src/main/java/io/github/timoa/lombok/ConvertNoArgsConstructor.java
- lines 76-78
- src/main/java/io/github/timoa/lombok/ConvertSetter.java
- lines 127-129
- src/main/java/io/github/timoa/lombok/LombokUtils.java
- lines 65-66
- src/main/java/io/github/timoa/lombok/SummarizeData.java
- lines 99-103
- src/main/java/io/github/timoa/lombok/SummarizeGetter.java
- lines 106-107
- lines 120-124
- src/main/java/io/github/timoa/lombok/SummarizeSetter.java
- lines 96-97
- lines 110-111
- lines 124-129
- src/main/java/io/github/timoa/misc/UseRanges.java
- lines 43-50
- lines 84-91
- lines 125-132
- lines 166-173
- lines 207-214
- lines 248-255
- lines 289-296
- lines 330-337
timo-a
changed the title
timo-a
added a commit
that referenced
this pull request
Oct 3, 2024
with exceptions (I don't like `:` and `?` of the ternary operator at the end of the line)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.