Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug: testing my style #3

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Debug: testing my style #3

merged 9 commits into from
Oct 4, 2024

Conversation

timo-a
Copy link
Owner

@timo-a timo-a commented Sep 13, 2024 •
edited
Loading

I'm unsure how to test my style so I get the same errors in the test that I get from applying it on a real project.
The inline test works, but that is not what happens when I apply my style on a real project.
The second test fails (which is what I observe in practice), but I'm unsure if I instantiate the style correct in the test.

github-actions[bot]
github-actions bot reviewed Sep 13, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/io/github/timoa/lombok/ConvertNoArgsConstructor.java
    • lines 69-71
  • src/main/java/io/github/timoa/lombok/ConvertSetter.java
    • lines 148-148
    • lines 168-168
  • src/main/java/io/github/timoa/lombok/LombokUtils.java
    • lines 33-34
  • src/main/java/io/github/timoa/lombok/NormalizeGetter.java
    • lines 21-21
    • lines 158-159
  • src/main/java/io/github/timoa/lombok/NormalizeSetter.java
    • lines 21-21
    • lines 169-170
  • src/main/java/io/github/timoa/lombok/SummarizeData.java
    • lines 21-21
    • lines 39-40
    • lines 66-65
  • src/main/java/io/github/timoa/lombok/log/ConvertCommons.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertJBoss.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertLog4j2.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertSlf4j.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertUtilLog.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/LogVisitor.java
    • lines 50-51
  • src/main/java/io/github/timoa/misc/UseRanges.java
    • lines 23-23
    • lines 74-73
    • lines 155-154
    • lines 236-235
    • lines 317-316
    • lines 360-360
  • src/test/java/io/github/timoa/lombok/log/ConvertAnyLogTest.java
    • lines 11-11
  • src/test/java/io/github/timoa/misc/UseRangesTest.java
    • lines 168-168

src/main/java/io/github/timoa/JacksonImportStyle.java Outdated Show resolved Hide resolved
src/test/java/com/yourorg/JacksonImportStyleTest.java Outdated Show resolved Hide resolved
src/test/java/com/yourorg/JacksonImportStyleTest.java Outdated Show resolved Hide resolved
@timo-a timo-a mentioned this pull request Sep 13, 2024
Closed
@timo-a timo-a force-pushed the debug/testing-my-style branch from 789d570 to 6454311 Compare October 3, 2024 10:56
github-actions[bot]
github-actions bot reviewed Oct 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/io/github/timoa/lombok/ConvertGetter.java
    • lines 125-127
  • src/main/java/io/github/timoa/lombok/ConvertNoArgsConstructor.java
    • lines 44-45
    • lines 69-74
  • src/main/java/io/github/timoa/lombok/ConvertSetter.java
    • lines 127-129
    • lines 148-148
    • lines 168-168
  • src/main/java/io/github/timoa/lombok/LombokUtils.java
    • lines 24-25
    • lines 33-34
    • lines 54-55
    • lines 66-67
    • lines 78-79
  • src/main/java/io/github/timoa/lombok/NegligentlyConvertEquals.java
    • lines 23-23
  • src/main/java/io/github/timoa/lombok/NormalizeGetter.java
    • lines 21-21
    • lines 158-159
  • src/main/java/io/github/timoa/lombok/NormalizeSetter.java
    • lines 21-21
    • lines 169-170
  • src/main/java/io/github/timoa/lombok/SummarizeData.java
    • lines 21-21
    • lines 39-40
    • lines 66-65
    • lines 99-103
  • src/main/java/io/github/timoa/lombok/SummarizeGetter.java
    • lines 26-26
    • lines 107-108
    • lines 121-125
  • src/main/java/io/github/timoa/lombok/SummarizeSetter.java
    • lines 26-26
    • lines 97-98
    • lines 111-112
    • lines 125-130
  • src/main/java/io/github/timoa/lombok/log/ConvertCommons.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertJBoss.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertLog4j2.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertSlf4j.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertUtilLog.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/LogVisitor.java
    • lines 50-51
  • src/main/java/io/github/timoa/misc/NormalizeBigDecimalCreation.java
    • lines 5-7
    • lines 17-19
  • src/main/java/io/github/timoa/misc/UseRanges.java
    • lines 23-23
    • lines 43-50
    • lines 74-73
    • lines 83-90
    • lines 124-131
    • lines 155-154
    • lines 164-171
    • lines 205-212
    • lines 236-235
    • lines 245-252
    • lines 286-293
    • lines 317-316
    • lines 326-333
    • lines 360-360
  • src/test/java/io/github/timoa/lombok/log/ConvertAnyLogTest.java
    • lines 11-11
  • src/test/java/io/github/timoa/misc/NormalizeBigDecimalCreationTest.java
    • lines 11-11
  • src/test/java/io/github/timoa/misc/UseRangesTest.java
    • lines 168-168

github-actions[bot]
github-actions bot reviewed Oct 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/io/github/timoa/lombok/ConvertGetter.java
    • lines 125-127
  • src/main/java/io/github/timoa/lombok/ConvertNoArgsConstructor.java
    • lines 44-45
    • lines 69-74
  • src/main/java/io/github/timoa/lombok/ConvertSetter.java
    • lines 127-129
    • lines 148-148
    • lines 168-168
  • src/main/java/io/github/timoa/lombok/LombokUtils.java
    • lines 24-25
    • lines 33-34
    • lines 54-55
    • lines 66-67
    • lines 78-79
  • src/main/java/io/github/timoa/lombok/NegligentlyConvertEquals.java
    • lines 23-23
  • src/main/java/io/github/timoa/lombok/NormalizeGetter.java
    • lines 21-21
    • lines 158-159
  • src/main/java/io/github/timoa/lombok/NormalizeSetter.java
    • lines 21-21
    • lines 169-170
  • src/main/java/io/github/timoa/lombok/SummarizeData.java
    • lines 21-21
    • lines 39-40
    • lines 66-65
    • lines 99-103
  • src/main/java/io/github/timoa/lombok/SummarizeGetter.java
    • lines 26-26
    • lines 107-108
    • lines 121-125
  • src/main/java/io/github/timoa/lombok/SummarizeSetter.java
    • lines 26-26
    • lines 97-98
    • lines 111-112
    • lines 125-130
  • src/main/java/io/github/timoa/lombok/log/ConvertCommons.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertJBoss.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertLog4j2.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertSlf4j.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/ConvertUtilLog.java
    • lines 20-20
  • src/main/java/io/github/timoa/lombok/log/LogVisitor.java
    • lines 50-51
  • src/main/java/io/github/timoa/misc/NormalizeBigDecimalCreation.java
    • lines 5-7
    • lines 17-19
  • src/main/java/io/github/timoa/misc/UseRanges.java
    • lines 23-23
    • lines 43-50
    • lines 74-73
    • lines 83-90
    • lines 124-131
    • lines 155-154
    • lines 164-171
    • lines 205-212
    • lines 236-235
    • lines 245-252
    • lines 286-293
    • lines 317-316
    • lines 326-333
    • lines 360-360
  • src/test/java/io/github/timoa/lombok/log/ConvertAnyLogTest.java
    • lines 11-11
  • src/test/java/io/github/timoa/misc/NormalizeBigDecimalCreationTest.java
    • lines 11-11
  • src/test/java/io/github/timoa/misc/UseRangesTest.java
    • lines 168-168

src/test/java/io/github/timoa/JacksonImportStyleTest.java Outdated
Comment on lines 12 to 14
import java.util.Arrays;

import static java.util.Collections.*;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import java.util.Arrays;
import static java.util.Collections.*;
import static java.util.Collections.emptySet;
import static java.util.Collections.singletonList;

timo-abele and others added 3 commits October 3, 2024 14:36
@timo-abele @timo-a
add: custom style for ordering imports
8feee9a 
# Conflicts:
#	src/main/java/io/github/timoa/JacksonImportStyle.java
@timo-a
write tests
9284118
@timo-a
fix+refactor recipe
988a58a
@timo-a timo-a force-pushed the debug/testing-my-style branch from 8dbb382 to 988a58a Compare October 3, 2024 12:36
github-actions[bot]
github-actions bot reviewed Oct 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/io/github/timoa/lombok/ConvertGetter.java
    • lines 125-127
  • src/main/java/io/github/timoa/lombok/ConvertNoArgsConstructor.java
    • lines 76-78
  • src/main/java/io/github/timoa/lombok/ConvertSetter.java
    • lines 127-129
  • src/main/java/io/github/timoa/lombok/LombokUtils.java
    • lines 65-66
  • src/main/java/io/github/timoa/lombok/SummarizeData.java
    • lines 99-103
  • src/main/java/io/github/timoa/lombok/SummarizeGetter.java
    • lines 106-107
    • lines 120-124
  • src/main/java/io/github/timoa/lombok/SummarizeSetter.java
    • lines 96-97
    • lines 110-111
    • lines 124-129
  • src/main/java/io/github/timoa/misc/UseRanges.java
    • lines 43-50
    • lines 84-91
    • lines 125-132
    • lines 166-173
    • lines 207-214
    • lines 248-255
    • lines 289-296
    • lines 330-337

src/test/java/io/github/timoa/JacksonImportStyleTest.java Outdated
Comment on lines 12 to 15
import java.util.Arrays;

import static java.util.Collections.*;
import static org.openrewrite.Tree.randomId;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import java.util.Arrays;
import static java.util.Collections.*;
import static org.openrewrite.Tree.randomId;
import static java.util.Collections.emptySet;
import static java.util.Collections.singletonList;

github-actions[bot]
github-actions bot reviewed Oct 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/io/github/timoa/lombok/ConvertGetter.java
    • lines 125-127
  • src/main/java/io/github/timoa/lombok/ConvertNoArgsConstructor.java
    • lines 76-78
  • src/main/java/io/github/timoa/lombok/ConvertSetter.java
    • lines 127-129
  • src/main/java/io/github/timoa/lombok/LombokUtils.java
    • lines 65-66
  • src/main/java/io/github/timoa/lombok/SummarizeData.java
    • lines 99-103
  • src/main/java/io/github/timoa/lombok/SummarizeGetter.java
    • lines 106-107
    • lines 120-124
  • src/main/java/io/github/timoa/lombok/SummarizeSetter.java
    • lines 96-97
    • lines 110-111
    • lines 124-129
  • src/main/java/io/github/timoa/misc/UseRanges.java
    • lines 43-50
    • lines 84-91
    • lines 125-132
    • lines 166-173
    • lines 207-214
    • lines 248-255
    • lines 289-296
    • lines 330-337

src/test/java/io/github/timoa/misc/JacksonImportStyleTest.java Outdated Show resolved Hide resolved
@timo-a timo-a force-pushed the debug/testing-my-style branch from e6ee451 to 311604d Compare October 3, 2024 21:43
github-actions[bot]
github-actions bot reviewed Oct 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/io/github/timoa/lombok/ConvertGetter.java
    • lines 125-127
  • src/main/java/io/github/timoa/lombok/ConvertNoArgsConstructor.java
    • lines 76-78
  • src/main/java/io/github/timoa/lombok/ConvertSetter.java
    • lines 127-129
  • src/main/java/io/github/timoa/lombok/LombokUtils.java
    • lines 65-66
  • src/main/java/io/github/timoa/lombok/SummarizeData.java
    • lines 99-103
  • src/main/java/io/github/timoa/lombok/SummarizeGetter.java
    • lines 106-107
    • lines 120-124
  • src/main/java/io/github/timoa/lombok/SummarizeSetter.java
    • lines 96-97
    • lines 110-111
    • lines 124-129
  • src/main/java/io/github/timoa/misc/UseRanges.java
    • lines 43-50
    • lines 84-91
    • lines 125-132
    • lines 166-173
    • lines 207-214
    • lines 248-255
    • lines 289-296
    • lines 330-337

github-actions[bot]
github-actions bot reviewed Oct 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/io/github/timoa/lombok/ConvertGetter.java
    • lines 125-127
  • src/main/java/io/github/timoa/lombok/ConvertNoArgsConstructor.java
    • lines 76-78
  • src/main/java/io/github/timoa/lombok/ConvertSetter.java
    • lines 127-129
  • src/main/java/io/github/timoa/lombok/LombokUtils.java
    • lines 65-66
  • src/main/java/io/github/timoa/lombok/SummarizeData.java
    • lines 99-103
  • src/main/java/io/github/timoa/lombok/SummarizeGetter.java
    • lines 106-107
    • lines 120-124
  • src/main/java/io/github/timoa/lombok/SummarizeSetter.java
    • lines 96-97
    • lines 110-111
    • lines 124-129
  • src/main/java/io/github/timoa/misc/UseRanges.java
    • lines 43-50
    • lines 84-91
    • lines 125-132
    • lines 166-173
    • lines 207-214
    • lines 248-255
    • lines 289-296
    • lines 330-337

github-actions[bot]
github-actions bot reviewed Oct 4, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/io/github/timoa/lombok/ConvertGetter.java
    • lines 125-127
  • src/main/java/io/github/timoa/lombok/ConvertNoArgsConstructor.java
    • lines 76-78
  • src/main/java/io/github/timoa/lombok/ConvertSetter.java
    • lines 127-129
  • src/main/java/io/github/timoa/lombok/LombokUtils.java
    • lines 65-66
  • src/main/java/io/github/timoa/lombok/SummarizeData.java
    • lines 99-103
  • src/main/java/io/github/timoa/lombok/SummarizeGetter.java
    • lines 106-107
    • lines 120-124
  • src/main/java/io/github/timoa/lombok/SummarizeSetter.java
    • lines 96-97
    • lines 110-111
    • lines 124-129
  • src/main/java/io/github/timoa/misc/UseRanges.java
    • lines 43-50
    • lines 84-91
    • lines 125-132
    • lines 166-173
    • lines 207-214
    • lines 248-255
    • lines 289-296
    • lines 330-337

@timo-a timo-a merged commit f58e68e into main Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timo-a @timo-abele