Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LyricAccessories to LyricAccessory #79

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

dalinicus
Copy link
Contributor

Properly reflect the object is a single accessory, not a collection of accessories.

[x] Unit tests pass locally
[x] ran python -m incremental.update aiolyric --patch

Let me know if this was an incorrect way to bump the version number.

Properly reflect the object is a single accessory, not a collection of accessories
@dalinicus
Copy link
Contributor Author

Not sure what's going on with the failed checks here. Looks like GitHub failed to pull my fork branch?

Copy link
Owner

@timmo001 timmo001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Versioning is handled by the deploy workflow

@timmo001
Copy link
Owner

timmo001 commented Apr 21, 2024

Not sure what's going on with the failed checks here. Looks like GitHub failed to pull my fork branch?

Not sure why it does that when the changes are from a fork

@timmo001 timmo001 merged commit 7ad690c into timmo001:master Apr 21, 2024
5 of 13 checks passed
@timmo001 timmo001 added the maintenance Generic maintenance tasks. label Apr 21, 2024
@dalinicus dalinicus deleted the bugfix/rename-accesory-object branch April 21, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Generic maintenance tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants